Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hexadecimal and base64 encoded DER certificates #386

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

manicminer
Copy link
Member

@manicminer manicminer commented Jan 19, 2021

For azuread_application_certificate and azuread_service_principal_certificate resources.

Adds an encoding property which defaults to "pem" and supports:

  • pem - the currently supported PEM encoding
  • base64 - base64 encoded DER certificate
  • hex - hexadecimal encoded DER certificate, i.e. as exported by azurerm_key_vault_certificate

Closes: #385

@manicminer
Copy link
Member Author

Test results

Screenshot 2021-01-19 at 23 20 32
Screenshot 2021-01-19 at 23 20 56

@manicminer manicminer force-pushed the feature/app-sp-cert-encodings branch 2 times, most recently from 19e25e0 to 3c69a32 Compare January 19, 2021 23:37
@manicminer manicminer changed the title Support hexadecimal and (base64 encoded) der certificate encodings Support hexadecimal and base64 encoded DER certificates Jan 19, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 8863d0b into main Jan 28, 2021
manicminer added a commit that referenced this pull request Jan 28, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 1.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
@manicminer manicminer deleted the feature/app-sp-cert-encodings branch February 27, 2021 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants