Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign_in_audience in Azure AD Application doesn't support AzureADandPersonalMicrosoftAccount #475

Closed
Szer opened this issue Jul 2, 2021 · 3 comments

Comments

@Szer
Copy link

Szer commented Jul 2, 2021

According to Azure AD Docs there are 34 possible audience for Azure App:

  • AzureADMyOrg
  • AzureADMultipleOrgs
  • AzureADandPersonalMicrosoftAccount
  • PersonalMicrosoftAccount

Latest (1.6.0) azuread provider supports only 2 out of 4:
https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/resources/application#sign_in_audience
with AzureADMyOrg by default.

When I'm trying to create App with unsupported audience I get expected error:
Error: expected sign_in_audience to be one of [AzureADMyOrg AzureADMultipleOrgs], got AzureADandPersonalMicrosoftAccount

Could you please add support for AzureADandPersonalMicrosoftAccount?

Updated: There are actually 4 possible audience. Added PersonalMicrosoftAccount

@manicminer
Copy link
Contributor

Hi @Szer, thanks for requesting this feature. We recently merged support for AzureADandPersonalMicrosoftAccount and PersonalMicrosoftAccount values for the sign_in_audience property and this will be included in the next release of the provider. For some additional context, the next release of the provider will be a major release (v2.0) which includes many new features that we were previously unable to add without introducing breaking changes. You can find out more about this in #323.

This particular feature was already requested in #408, as such I'm going to close this one as a duplicate. We appreciate your feature requests and encourage you to open further issues if there's a feature missing that isn't already covered in an existing issue. Thanks!

@manicminer
Copy link
Contributor

Duplicate of #408

@manicminer manicminer marked this as a duplicate of #408 Jul 2, 2021
@manicminer manicminer added this to the v2.0.0 milestone Jul 2, 2021
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants