-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow reading oauth2 permissions from aad application #79
allow reading oauth2 permissions from aad application #79
Conversation
@janschumann Thanks for doing the "boring" stuff. I am looking forward for this being merged into the provider soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the enhancement @janschumann,
I've left a few comments inline
0bf7646
to
1611566
Compare
@katbyte, is the review ok now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revision @janschumann, aside from one minor comment this LGTM 👍 hope you don't mind but i am going to push a change to resolve the one outstanding issue so i can merge this today 🙂
"oauth2_permissions": { | ||
Type: schema.TypeList, | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this block is only exported/computed this can be removed
Computed: true, |
Hi, is there an ETA for a release with this fix please ? |
I am curious about the syntax to use. If I have an application like so :
what is the syntax to access the id of an oauth2_permissions block? |
I manage to do it this way: |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Adds the
oauth2Permissions
manifest attribute to the exported attributes of aazuread_application
resource and data resource.https://docs.microsoft.com/en-us/azure/active-directory/develop/reference-app-manifest