-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group writeback functionality #964
Conversation
@tomasmota I'm keen to get this merged, but I am having issues whilst testing. After enabling writeback for a group, it starts to misbehave and certain requests to GET or PATCH the group start to return a 404 or 403. It seems to be reproducible but I am not sure whether it's something we're doing wrong or whether the API is misbehaving. I'll dig more into this next week, but for now I have pushed some changes including some docs fixups and bumping Hamilton to pull in the casing fixes. |
Thanks for testing this out. Have you managed to reproduce it just using hamilton? |
Let me know if there is anything I can do to help troubleshooting this @manicminer |
@tomasmota Thanks, at this time I am still having issues whilst testing. I'll have to unfortunately bump to next week but will spend time digging deeper in the meantime. |
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Tomás Mota <tmm@danskecommodities.com>
1ad3946
to
e0c7ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomasmota Good news, the earlier issues with spontaneous 40x responses seem to be resolved. After rebasing and tweaking the schema, this is working great. Thanks again for working on this 👍
This functionality has been released in v2.37.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Fixes #934
Depends on manicminer/hamilton#199