data source directory_role_templates

[MattGarnerAWR]

My 1st attempt at a PR to add a new data source for directory role templates :)

[manicminer]

Hi @MattGarnerAWR, thank you for this PR! This is looking great, and I do not have any changes to suggest beyond what the tests have flagged - just a couple questions to clarify before we look to merge this.

[MattGarnerAWR]

Hi @MattGarnerAWR, thank you for this PR! This is looking great, and I do not have any changes to suggest beyond what the tests have flagged - just a couple questions to clarify before we look to merge this.

Thanks @manicminer , I have resolved all of them and hopefully the right package will mean the tests run this time :)

[manicminer]

Thanks @MattGarnerAWR, just a couple minor tweakd which I've made below but otherwise LGTM 👍

[manicminer]

@MattGarnerAWR Just a couple things to note:

• New resources / data sources need to be registered, typically there's a registration.go file in each package for this
• Whenever we dereference a pointer, we need to first check that it's non-nil or it may cause a crash at runtime

I fixed these up in the PR as I didn't spot them earlier on, hope you don't mind. Thanks again for the contribution!

[MattGarnerAWR]

@MattGarnerAWR Just a couple things to note:

• New resources / data sources need to be registered, typically there's a registration.go file in each package for this
• Whenever we dereference a pointer, we need to first check that it's non-nil or it may cause a crash at runtime

I fixed these up in the PR as I didn't spot them earlier on, hope you don't mind. Thanks again for the contribution!

Thanks for your help!

[github-actions]

This functionality has been released in v2.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!