Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: run d.Partial() to avoid setting invalid password to state when a user update fails #1379

Merged
merged 1 commit into from
May 16, 2024

Conversation

manicminer
Copy link
Member

Resolves #1308

@manicminer manicminer force-pushed the bug/user-password-set-on-failure branch from b938fc9 to 16c62b1 Compare May 15, 2024 23:05
@manicminer
Copy link
Member Author

Test results

Screenshot 2024-05-16 at 00 06 01

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 67aac96 into main May 16, 2024
25 checks passed
@manicminer manicminer deleted the bug/user-password-set-on-failure branch May 16, 2024 15:06
@github-actions github-actions bot added this to the v2.50.0 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State is updated with new password, even when password change failed.
2 participants