-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfixes for ID parsing #1499
Merged
Merged
bugfixes for ID parsing #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_strength_policy_id`
…for `service_principal_id`
…ng bug for `service_principal_id`
… `service_principal_id` and `synchronization_job_id`
Also got ID parsing errors on |
…ead_service_principal_delegated_permission_grant` - user segment is not a UUID
jackofallops
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manicminer - LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data.azuread_group
: fix ID parsing bugs and some panicsazuread_conditional_access_policy
: fix parsing bug forauthentication_strength_policy_id
azuread_service_principal_certificate
: fix parsing bug forservice_principal_id
azuread_service_principal_claims_mapping_policy_assignment
: fix parsing bug forservice_principal_id
azuread_service_principal_password
: fix parsing bug forservice_principal_id
azuread_service_principal_token_signing_certificate
: fix parsing bug forservice_principal_id
azuread_synchronization_job
: fix parsing bug forservice_principal_id
azuread_synchronization_job_provision_on_demand
: fix parsing bugs forservice_principal_id
andsynchronization_job_id
azuread_synchronization_secret
: fix parsing bug forservice_principal_id
and documentation updates
Resolves: #1497
Resolves: #1498
Test results
Conditional Access
Groups
Failures unrelated.
Service Principals
Synchronization