New Resource: `azurerm_custom_hostname_bindings #1087
Conversation
Tests pass:
```
$ acctests azurerm TestAccAzureRMAppServiceCustomHostnameBinding
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding/basic
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding/basic/basic
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding/basic/import
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding (223.11s)
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding/basic (223.10s)
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding/basic/basic (124.19s)
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding/basic/import (98.92s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 223.140s
```
| // Ensure we have enough information in state to look up in API | ||
| rs, ok := s.RootModule().Resources[name] | ||
| if !ok { | ||
| return fmt.Errorf("Not found: %s", name) |
There was a problem hiding this comment.
in general we don’t for these since this is the resource name (eg “azurerm_resource_group”) rather than the name property of the resource so generally we just output those raw (since it means the resource is missing from the state) - but I can update this?
|
@tombuildsstuff thanks...was hoping to not have to do this out of band of our automation. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Allows the configuration of Custom Hostname Bindings (e.g.
www.example.com) to point to an Azure App Service.Within our CI system this'll need two new variables configured (
ARM_TEST_APP_SERVICEandARM_TEST_DOMAIN) for the acceptance tests - since the Custom Hostname used must have a CNAME to the Azure App Service; which I'll add once this is merged.Tests pass:
Fixes #1026