Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_app_service - adding support for HTTP2 #1188

Merged
merged 3 commits into from
May 2, 2018
Merged

azurerm_app_service - adding support for HTTP2 #1188

merged 3 commits into from
May 2, 2018

Conversation

tombuildsstuff
Copy link
Contributor 

$ acctests azurerm TestAccAzureRMAppService_http2Enabled
=== RUN   TestAccAzureRMAppService_http2Enabled
--- PASS: TestAccAzureRMAppService_http2Enabled (98.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	98.568s

@tombuildsstuff tombuildsstuff added this to the 1.5.0 milestone May 1, 2018
@tombuildsstuff tombuildsstuff requested a review from a team May 1, 2018 14:51
@tombuildsstuff
Copy link
Contributor Author

Will also push a commit to expose this within the data source

@tombuildsstuff tombuildsstuff changed the title azurerm_app_service - adding support for HTTP2 [WIP] azurerm_app_service - adding support for HTTP2 May 1, 2018
@tombuildsstuff
azurerm_app_service - adding support for HTTP2
152a7c5 
```
$ acctests azurerm TestAccAzureRMAppService_http2Enabled
=== RUN   TestAccAzureRMAppService_http2Enabled
--- PASS: TestAccAzureRMAppService_http2Enabled (98.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	98.568s
```
@tombuildsstuff
Moving the http2_enabled property to the right place
7da70d6
@tombuildsstuff
Adding http2_enabled to the data source
795e166
@tombuildsstuff tombuildsstuff changed the title [WIP] azurerm_app_service - adding support for HTTP2 azurerm_app_service - adding support for HTTP2 May 1, 2018
@tombuildsstuff
Copy link
Contributor Author

Data source test:

$ acctests azurerm TestAccDataSourceAzureRMAppService_http2Enabled
=== RUN   TestAccDataSourceAzureRMAppService_http2Enabled
--- PASS: TestAccDataSourceAzureRMAppService_http2Enabled (255.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	256.022s

@tombuildsstuff
Copy link
Contributor Author

Resource tests pass:

screen shot 2018-05-01 at 16 25 13

Data source tests pass:

screen shot 2018-05-01 at 16 54 33

katbyte
katbyte approved these changes May 1, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 4432085 into master May 2, 2018
@tombuildsstuff tombuildsstuff deleted the app-service-http2 branch May 2, 2018 07:16
tombuildsstuff added a commit that referenced this pull request May 2, 2018
@tombuildsstuff
Updating to include #1188
65aa4f3
@tombuildsstuff tombuildsstuff mentioned this pull request May 3, 2018
Closed
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
enhancement service/app-service
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte