Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM Data Disk Attachment: support for setting Write Accelerator Enabled #1473

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 2, 2018

acctests azurerm TestAccAzureRMVirtualMachineDataDiskAttachment_updatingWriteAccelerator
=== RUN   TestAccAzureRMVirtualMachineDataDiskAttachment_updatingWriteAccelerator
--- PASS: TestAccAzureRMVirtualMachineDataDiskAttachment_updatingWriteAccelerator (1068.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1068.861s

Fixes #1468

```
acctests azurerm TestAccAzureRMVirtualMachineDataDiskAttachment_updatingWriteAccelerator
=== RUN   TestAccAzureRMVirtualMachineDataDiskAttachment_updatingWriteAccelerator
--- PASS: TestAccAzureRMVirtualMachineDataDiskAttachment_updatingWriteAccelerator (1068.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1068.861s
```
@tombuildsstuff tombuildsstuff added this to the 1.9.0 milestone Jul 2, 2018
@tombuildsstuff tombuildsstuff requested a review from a team July 2, 2018 05:25
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 9863a1c into master Jul 2, 2018
@tombuildsstuff tombuildsstuff deleted the disks-write-accelerator branch July 2, 2018 12:33
tombuildsstuff added a commit that referenced this pull request Jul 2, 2018
tombuildsstuff added a commit that referenced this pull request Jul 2, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to specify "write_accelerator_enabled" in new resource azurerm_virtual_machine_data_disk_attachment
2 participants