Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to v18.0.0 of Azure/azure-sdk-for-go / v10.12.0 of Azure/go-autorest #1487

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Need to upgrade the SDK to use the new version of the HDInsights API

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon you ran the acceptance tests for relevant resources? If so, then 👍

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there seems to be a test failure. Can you take a look?

@lfshr
Copy link
Contributor

lfshr commented Jul 4, 2018

#1488 depends on this

@tombuildsstuff
Copy link
Contributor Author

Tests look good 👍

@tombuildsstuff tombuildsstuff merged commit 2f03253 into master Jul 4, 2018
@tombuildsstuff tombuildsstuff deleted the sdk-upgrade branch July 4, 2018 16:26
tombuildsstuff added a commit that referenced this pull request Jul 4, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants