Add run command enabled parameter to AKS cluster

[phillebaba]

The run command feature in AKS is now GA and is enabled by default.

https://azure.microsoft.com/en-us/updates/public-preview-of-azure-kubernetes-service-aks-runcommand-feature/

This change adds an option to disable the feature.

[stephybun]

Thanks for this PR @phillebaba. Overall this is off to a good start. I left a comment inline and could you also add a test that toggles the value for run_command_enabled? Once that's there and the docs are updated we can have another look at this.

[phillebaba]

@stephybun fixed most of your comments now. Regarding the toggling test. Is there a standard pipeline which runs the e2e tests or are they only run client side?

[stephybun]

@phillebaba we have a TeamCity instance that runs all of our acceptance tests nightly, so the test is essential to getting this merged. Unfortunately while I was taking a closer look at this I noticed that this property isn't returned from the AKS API at all, regardless of whether set to true or false (you'll see this when you add the toggle test). We have a meeting with the AKS team this Friday where we will address this issue.

[phillebaba]

@stephybun took a while for me to find time and solve the last issues.

I have resolved your comments and added a acceptance test toggling the setting.

$ make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_runCommand' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_runCommand -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_runCommand
=== PAUSE TestAccKubernetesCluster_runCommand
=== CONT  TestAccKubernetesCluster_runCommand
--- PASS: TestAccKubernetesCluster_runCommand (746.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/containers	746.150s

[stephybun]

Thanks @phillebaba LGTM 🚀

[github-actions]

This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.