Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account: limit tag names to 128 characters #1524

Merged
merged 2 commits into from
Jul 10, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jul 9, 2018

fixes #1511

@katbyte katbyte added this to the 1.9.0 milestone Jul 9, 2018
@katbyte katbyte requested a review from tombuildsstuff July 9, 2018 23:37
@katbyte
Copy link
Collaborator Author

katbyte commented Jul 9, 2018

tests pass:
screen shot 2018-07-09 at 16 47 37

(the two failed are because "cannon disable encryption on this account")

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a commit to fix the ordering on the imports - but this otherwise LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 214e3a8 into master Jul 10, 2018
@tombuildsstuff tombuildsstuff deleted the b-storageaccount-tagname branch July 10, 2018 07:20
tombuildsstuff added a commit that referenced this pull request Jul 10, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure defined azurerm_storage_accounts tag character limits not handled
2 participants