r\linux_virtual_machine_scale_set r\windows_virtual_machine_scale_set: Rename terminate_notification to termination_notification
#15570
Conversation
…set`: Rename `terminate_notification` to `termination_notification`
myc2h6o
force-pushed
the
termination_notification_rename
branch
from
56c66ef to
1fcf5bf
Compare
myc2h6o
changed the title
r\orchestrated_virtual_machine_scale_set: Rename termination_notification to terminate_notificationr\windows_virtual_machine_scale_set: Rename terminate_notification to termination_notification
myc2h6o
changed the title
r\windows_virtual_machine_scale_set: Rename terminate_notification to termination_notificationr\linux_virtual_machine_scale_set r\windows_virtual_machine_scale_set: Rename terminate_notification to termination_notification
|
Hi @katbyte Thanks for the comment, yes |
|
Test result after update: |
|
This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
myc2h6o
force-pushed
the
termination_notification_rename
branch
from
d038282 to
dd5af47
Compare
|
Updated test result |
| } | ||
|
|
||
| if !features.FourPointOhBeta() { | ||
| out["terminate_notification"] = VirtualMachineScaleSetTerminateNotificationSchema() |
There was a problem hiding this comment.
we should be adding a deprecated message to this property directing users to the new one?
There was a problem hiding this comment.
Yeah, it's added in VirtualMachineScaleSetTerminateNotificationSchema in virtual_machine_scale_set.go:
| Optional: true, | ||
| Computed: true, | ||
| MaxItems: 1, | ||
| Deprecated: "`terminate_notification` has been renamed to `termination_notification` and will be removed in 4.0.", |
There was a problem hiding this comment.
Deprecation notice is put here
| } | ||
|
|
||
| if !features.FourPointOhBeta() { | ||
| out["terminate_notification"] = VirtualMachineScaleSetTerminateNotificationSchema() |
|
This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Updated per comment
--------
Updating the property name to the correct word and match the one in
r\orchestrated_virtual_machine_scale_set.terraform-provider-azurerm/internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go
Line 193 in f232d0a
This property is
Optional+Computed, so in theUpdatefunction, by simply checking theHasChangefor each of them, it can handle the migration from old property name to new one (If property name changes with value remaining same, no changes are detected).