Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_[linux|windows]_function_app and azurerm_[linux|windows]_function_app_slot - support Key Vault Secret for storage connection string #15793

Merged
merged 6 commits into from
Mar 18, 2022
Merged

azurerm_[linux|windows]_function_app and azurerm_[linux|windows]_function_app_slot - support Key Vault Secret for storage connection string #15793

merged 6 commits into from
Mar 18, 2022

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Mar 10, 2022 •
edited
Loading

  • azurerm_linux_function_app - add support for storage_key_vault_secret_id

  • azurerm_windows_function_app - add support for storage_key_vault_secret_id

  • azurerm_linux_function_app_slot - add support for storage_key_vault_secret_id

  • azurerm_windows_function_app_slot - add support for storage_key_vault_secret_id

  • Data Source: azurerm_linux_function_app - add support for storage_key_vault_secret_id

  • Data Source: azurerm_windows_function_app - add support for storage_key_vault_secret_id

closes #15775

@jackofallops jackofallops requested a review from a team March 10, 2022 15:56
@jackofallops jackofallops self-assigned this Mar 10, 2022
@jackofallops jackofallops added this to the v2.99.0 milestone Mar 10, 2022
katbyte
katbyte approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏗️

@tombuildsstuff tombuildsstuff modified the milestones: v2.99.0, v3.0.0 Mar 11, 2022
fvdnabee
fvdnabee suggested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@fvdnabee fvdnabee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @jackofallops.

I would only propose to rename the storage_key_vault_secret_id argument and include a link to the MS docs on Key vault references.

internal/services/appservice/linux_function_app_data_source.go Show resolved Hide resolved
internal/services/appservice/linux_function_app_resource.go Show resolved Hide resolved
website/docs/r/windows_function_app_slot.html.markdown Outdated Show resolved Hide resolved
@jackofallops jackofallops merged commit 7322719 into main Mar 18, 2022
@jackofallops jackofallops deleted the b/app-service-kvid-bug branch March 18, 2022 09:20
jackofallops added a commit that referenced this pull request Mar 18, 2022
@jackofallops
Update for #15793
68d56ec
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@fvdnabee fvdnabee fvdnabee approved these changes

Assignees

@jackofallops jackofallops

Labels
documentation service/app-service size/XL
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Overwriting app_settings in azurerm_windows_function_app leads to incorrect TF state
4 participants
@jackofallops @fvdnabee @katbyte @tombuildsstuff