Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_windows_function_app node version validation strings. #15884

Merged
merged 2 commits into from
Mar 21, 2022
Merged

azurerm_windows_function_app node version validation strings. #15884

merged 2 commits into from
Mar 21, 2022

Conversation

jackofallops
Copy link
Member

Also adds support for Node 16 preview.

closes #15852

@jackofallops jackofallops added this to the v3.0.0 milestone Mar 18, 2022
@jackofallops jackofallops requested a review from a team March 18, 2022 11:27
@jackofallops jackofallops self-assigned this Mar 18, 2022
@jackofallops
Copy link
Member Author

Testing looks fine:

image

tombuildsstuff
tombuildsstuff approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but this otherwise seems fine 👍

internal/services/appservice/helpers/function_app_schema.go
"14",
"~12",
"~14",
"~16",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update the docs too?

@jackofallops jackofallops merged commit 27441ca into main Mar 21, 2022
@jackofallops jackofallops deleted the b/win-function-app-node-version branch March 21, 2022 13:46
jackofallops added a commit that referenced this pull request Mar 21, 2022
@jackofallops
Update for #15884
9881514
@mickare mickare mentioned this pull request Mar 21, 2022
Closed
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees

@jackofallops jackofallops

Labels
documentation service/app-service size/S
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

azurerm_windows_function_app sets incorrect WEBSITE_NODE_DEFAULT_VERSION app setting for node
2 participants
@jackofallops @tombuildsstuff