-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/azurerm_application_insights - provider feature disable_generated_rule isn't working #16124
Comments
(introduced by pr #15892) |
Ran into the same. It actually looks like the AppInsights resource gets properly created but TF doesn't realize that |
Hey @t3mi and @sebader, the change implemented in #15892 tries to disable both the Rule and Action Group that are created by Azure when spinning up an Application Insight resource (See #10563 for more context). Sometimes, that Action Group takes forever to spin up so we end up hitting our own create timeout just waiting to disable that Action Group. With that said, I believe just disabling the Rule should be enough as the Action Group is just acting on that Azure created rule and nothing else. Is that true? And if so, would it make sense to just disable the Rule and leave the Action Group alone? |
This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
@mbfrahry I just tested this in 3.1: So the deployment works now and indeed, the rules are not created anymore, the action group gets created, still. This still doesn't solve the actual problem with the new 3.x version: the default behavior of |
IIRC (from chatting with @mbfrahry about this) when deleting the Action Group it gets automatically recreated by the API (regardless of how many times you delete it/retry) - so I believe that maybe a service limitation at this time.
That's by design with this new feature, you can disable that behaviour using the feature-flag you've described above. Since this is now a service issue, I'd recommend filing an issue with the Service Team so that they can take a look into this - since (due to the auto-recreation issue above) this doesn't appear to be something we can fix in Terraform at this time unfortunately. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Terraform (and AzureRM Provider) Version
Terraform v1.0.11
on windows_amd64
Affected Resource(s)
azurerm_application_insights
Terraform Configuration Files
Debug Output
Panic Output
Expected Behaviour
No errors, application insights resource provisioned without default rules.
Actual Behaviour
Steps to Reproduce
terraform apply
Important Factoids
References
The text was updated successfully, but these errors were encountered: