Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\lb_outbound_rule Allow 0 for allocated_outbound_ports #16369

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Apr 13, 2022

Fix #16343

  • 0 seems to be a valid input for allocated_outbound_ports, adding validation and use d.Get instead of d.GetOk to include it.
  • Adding the missing default value of 1024 in doc
  • There seems to be not test around allocated_outbound_ports, adding it as well.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Apr 13, 2022

Test result
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@katbyte katbyte merged commit e452f8d into hashicorp:main Apr 14, 2022
@github-actions github-actions bot added this to the v3.2.0 milestone Apr 14, 2022
@myc2h6o myc2h6o deleted the outbound_rule branch April 14, 2022 03:42
katbyte added a commit that referenced this pull request Apr 14, 2022
@github-actions
Copy link

This functionality has been released in v3.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port allocation does not set to use the default number of outbound ports
2 participants