Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the connection information for a Virtual Machine #1646

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Setting the connection information for a Virtual Machine #1646

merged 1 commit into from
Jul 27, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 25, 2018 •
edited
Loading

Testing combinations:

  • Windows with a Public IP
  • Windows with a Private IP
  • Windows with multiple IP's
  • Linux with a Public IP
  • Linux with a Private IP
  • Linux with multiple IP's

Fixes #1645

@tombuildsstuff tombuildsstuff requested review from katbyte and a team and removed request for katbyte July 26, 2018 10:15
@tombuildsstuff tombuildsstuff changed the title [WIP] Setting the connection information for a Virtual Machine Setting the connection information for a Virtual Machine Jul 26, 2018
mbfrahry
mbfrahry approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor question

azurerm/resource_arm_virtual_machine.go
}
}
}
d.SetConnInfo(map[string]string{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care about setting this when ipAddress == ""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least one NIC is required in Azure (and we error above if one's not returned) - so I don't think this is an issue since the VM will always be in a booted state (and have an IP) at this stage

@tombuildsstuff
Copy link
Contributor Author

Ignoring a transient error within Azure the VM tests pass:

screenshot 2018-07-27 at 07 47 22

@tombuildsstuff tombuildsstuff merged commit 0ad123b into master Jul 27, 2018
@tombuildsstuff tombuildsstuff deleted the vm-connection-info branch July 27, 2018 05:48
tombuildsstuff added a commit that referenced this pull request Jul 27, 2018
@tombuildsstuff
Updating to include #1646
2900538
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement service/virtual-machine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting the connection info for a Virtual Machine
2 participants
@tombuildsstuff @mbfrahry