Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source/Resource: azurerm_cdn_frontdoor_rule_set #17094

Merged
merged 5 commits into from
Jun 9, 2022
Merged

New Data Source/Resource: azurerm_cdn_frontdoor_rule_set #17094

merged 5 commits into from
Jun 9, 2022

Conversation

tombuildsstuff
Copy link
Contributor

This PR introduces a new Data Source/Resource for azurerm_cdn_frontdoor_rule_set - split out from #16671

@tombuildsstuff tombuildsstuff added this to the v3.10.0 milestone Jun 3, 2022
@tombuildsstuff tombuildsstuff requested a review from a team June 3, 2022 13:12
@tombuildsstuff tombuildsstuff mentioned this pull request Jun 3, 2022
Merged
mbfrahry
mbfrahry requested changes Jun 3, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly good except for the datasource not following the cdn_frontdoor_profile_id of the resource

internal/services/cdn/cdn_frontdoor_rule_set_data_source.go

"resource_group_name": commonschema.ResourceGroupNameForDataSource(),

"cdn_frontdoor_profile_id": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the same format as the resource with just name and cdn_frontdoor_profile_id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, that's intentional since users may be referencing the Rule Set without the parents details

WodansSon
WodansSon approved these changes Jun 4, 2022
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

mbfrahry
mbfrahry approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 2d248af into main Jun 9, 2022
@mbfrahry mbfrahry deleted the f/cdn-frontdoor-rule-set branch June 9, 2022 19:02
mbfrahry added a commit that referenced this pull request Jun 9, 2022
@mbfrahry
Update changelog for #17094
6e0e004
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon approved these changes

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation new-data-source new-resource service/cdn size/XL
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tombuildsstuff @mbfrahry @WodansSon