azurerm_key_vault_managed_hardware_security_module - support for purging when soft deleted
#17148
Conversation
internal/services/keyvault/key_vault_managed_hardware_security_module_resource.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @mbfrahry - One really minor comment, otherwise LGTM 👍
| @@ -23,14 +23,14 @@ func TestAccKeyVaultManagedHardwareSecurityModule(t *testing.T) { | |||
| "basic": testAccDataSourceKeyVaultManagedHardwareSecurityModule_basic, | |||
| }, | |||
| "resource": { | |||
| "basic": testAccKeyVaultManagedHardwareSecurityModule_basic, | |||
| "basic": TestAccKeyVaultManagedHardwareSecurityModule_basic, | |||
There was a problem hiding this comment.
Was this case change for local testing? This will run twice in the test suite I think.
| "basic": TestAccKeyVaultManagedHardwareSecurityModule_basic, | |
| "basic": testAccKeyVaultManagedHardwareSecurityModule_basic, |
There was a problem hiding this comment.
🤦 yep! Thank you thank you!
| "update": testAccKeyVaultManagedHardwareSecurityModule_requiresImport, | ||
| "complete": testAccKeyVaultManagedHardwareSecurityModule_complete, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func testAccKeyVaultManagedHardwareSecurityModule_basic(t *testing.T) { | ||
| func TestAccKeyVaultManagedHardwareSecurityModule_basic(t *testing.T) { |
There was a problem hiding this comment.
as above
| func TestAccKeyVaultManagedHardwareSecurityModule_basic(t *testing.T) { | |
| func testAccKeyVaultManagedHardwareSecurityModule_basic(t *testing.T) { |
|
This functionality has been released in v3.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.