Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_gateway: add default value for backend_http_settings.0.request_timeout #17162

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jun 8, 2022

fixes #16695

After investigated, I found the request timeout has default value 30 when it isn't set in request payload. So TF always triggers the diff when it isn't specified in tf config.

--- PASS: TestAccApplicationGateway_withoutRequestTimeout (1717.51s)

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v3.10.0 milestone Jun 8, 2022
@mbfrahry mbfrahry changed the title azurerm_application_gateway: add default value for backend_http_settings.request_timeout azurerm_application_gateway: add default value for backend_http_settings.0.request_timeout Jun 8, 2022
@mbfrahry mbfrahry merged commit 599ae31 into hashicorp:main Jun 8, 2022
mbfrahry added a commit that referenced this pull request Jun 8, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Gateway bug on backend_http_settings causes constant updates
2 participants