Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\[linux|windows]_virtual_machine_scale_set: add support for capacity_reservation_group_id #17530

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Jul 6, 2022

Similar to VM implementation #17236, adding the support to VMSS. Capacity Reservation Group Id of Orchestrated VMSS is configured on each individual VM instead.

@myc2h6o myc2h6o force-pushed the vmss_capacity_reservation branch 2 times, most recently from aa8abc9 to e155ddc Compare July 6, 2022 15:49
@myc2h6o myc2h6o force-pushed the vmss_capacity_reservation branch from e155ddc to b495036 Compare July 6, 2022 16:05
@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jul 7, 2022

Test result
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌙

@katbyte katbyte merged commit 44c0d46 into hashicorp:main Jul 8, 2022
@github-actions github-actions bot added this to the v3.14.0 milestone Jul 8, 2022
katbyte added a commit that referenced this pull request Jul 8, 2022
@myc2h6o myc2h6o deleted the vmss_capacity_reservation branch July 9, 2022 03:49
@github-actions
Copy link

This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants