Added support for EventHub compatible EndPoints and Paths #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just updated documentation to reflect the 4 new exposed properties. |
szaroubi
changed the title
szaroubi
changed the title
tombuildsstuff
added
enhancement
service/event-hubs
tombuildsstuff
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
hey @szaroubi
Thanks for this PR - I've taken a look through and have left one comment (which I'm going to push a commit to fix) - but this otherwise LGTM 👍
Thanks!
website/docs/r/iothub.html.markdown
Outdated
| @@ -68,6 +68,10 @@ The following attributes are exported: | |||
|
|
|||
| * `shared_access_policy` - One or more `shared_access_policy` blocks as defined below. | |||
|
|
|||
| * `event_hub_[events|operations]_endpoint` - The EventHub compatible endpoint for either the events or operational data (in conjunction with the path and share access policy, can be used to build a connection string) | |||
|
|
|||
| * `event_hub_[events|operations]_path` - The EventHub compatible path for either the events or operational data (in conjunction with the endpoint and share access policy, can be used to build a connection string). | |||
There was a problem hiding this comment.
can we make this:
* `event_hub_events_endpoint` - The EventHub compatible endpoint for events data
* `event_hub_events_path` - The EventHub compatible path for events data
* `event_hub_operations_endpoint` - The EventHub compatible endpoint for operational data
* `event_hub_operations_path` - The EventHub compatible path for operational data
-> **NOTE:** These fields can be used in conjunction with the `shared_access_policy` block to build a connection string
|
Tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Aug 21, 2018
torresdal
added a commit
to torresdal/terraform-provider-azurerm
that referenced
this pull request
Aug 23, 2018
* master: (95 commits) Some more AzureStack changes for route table resource and datasource (hashicorp#1807) backport AzureStack route resource PR comments (hashicorp#1810) Updating to include hashicorp#1799 Bug Fix of azurerm_virtual_machine.storage_os_disk.image_uri (hashicorp#1799) Updating to include hashicorp#1693 IoT Hub add endpoints and routes (hashicorp#1693) Updating to include hashicorp#1789 Added support for EventHub compatible EndPoints and Paths (hashicorp#1789) Updating to include hashicorp#1798 Remove client side validation for azure network plugin (hashicorp#1798) backport azure stack route_table PR review comments (hashicorp#1790) Update CHAGELOG.md to include hashicorp#1795 Fix: Corrected regexp for eventhub name reset verb fix some pointer dereferences Fix indentation on application_gateway.html.markdown (hashicorp#1780) folded subscription and [az]schema packages into azure consolidate CaseDifference Supression functions Cleanup after v1.13.0 release v1.13.0 ...
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I am looking for feedback on this pull request.
The PR is the fulfill this feature request: #1743
It's a simple pull request whose objective is to expose the
EndpointandPathproperties of each Endpoint in the Events Hub Compatible endpoints that the IoT Gateway exposes.I created 4 new properties:
Fixes #1743