azurerm_linux_virtual_machine azurerm_windows_virtual_machine - support for gallery_applications

[myc2h6o]

This is similar to what we have added in VMSS. And gallery_applications in VM is updatable

terraform-provider-azurerm/website/docs/r/linux_virtual_machine_scale_set.html.markdown

Lines 363 to 373 in fa35df5

	A `gallery_applications` block supports the following:
	* `package_reference_id` - (Required) Specifies the Gallery Application Version resource ID. Changing this forces a new resource to be created.
	-> **NOTE:** The `package_reference_id` should be in the form of `/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.Compute/galleries/gallery1/applications/application1/versions/version1`.
	* `configuration_reference_blob_uri` - (Optional) Specifies the URI to an Azure Blob that will replace the default configuration for the package if provided. Changing this forces a new resource to be created.
	* `order` - (Optional) Specifies the order in which the packages have to be installed. Possible values are between `0` and `2,147,483,647`. Changing this forces a new resource to be created.
	* `tag` - (Optional) Specifies a passthrough value for more generic context. This field can be any valid `string` value. Changing this forces a new resource to be created.

[myc2h6o]

Test result (Failed tests are being fixed as part of #17671)

[katbyte]

should this be called

Suggested change

	* `package_reference_id` - (Required) Specifies the Gallery Application Version resource ID.
	-> **NOTE:** The `package_reference_id` should be in the form of `/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.Compute/galleries/gallery1/applications/application1/versions/version1`.
	* `version_id` - (Required) Specifies the Gallery Application Version resource ID.

or

Suggested change

	* `package_reference_id` - (Required) Specifies the Gallery Application Version resource ID.
	-> **NOTE:** The `package_reference_id` should be in the form of `/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.Compute/galleries/gallery1/applications/application1/versions/version1`.
	* `package_reference_id` - (Required) Specifies the Gallery Application Version resource ID.
	-> **NOTE:** The `gallery_application_version_id` should be in the form of `/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.Compute/galleries/gallery1/applications/application1/versions/version1`.

so the note sins't required?

[katbyte]

is reference make sense here?

Suggested change

	* `configuration_reference_blob_uri` - (Optional) Specifies the URI to an Azure Blob that will replace the default configuration for the package if provided.
	* `configuration_blob_uri` - (Optional) Specifies the URI to an Azure Blob that will replace the default configuration for the package if provided.

[katbyte]

this should be

Suggested change

	"gallery_applications": VirtualMachineGalleryApplicationsSchema(),
	"gallery_application": VirtualMachineGalleryApplicationsSchema(),

[myc2h6o]

Hi @katbyte thanks for reviewing the pr! The new property names you suggested totally make sense. Just the feature has just been added to VMSS with these property names (could be found in pr description), shall we use the same one from VMSS here, or use the new name instead, add deprecate those in VMSS?

[katbyte]

i think these names are sufficiently better the old ones should be deprecated ?

[myc2h6o]

@katbyte got it! I've updated the property names, please take a look.

[myc2h6o]

After this change is done, I'll start another pr to update these property names in VMSS resources

[katbyte]

LGTM 🌵

[github-actions]

This functionality has been released in v3.25.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[farwind]

seems like functionality was released for both linux and windows properly but release notes states only windows vitrual machine twice :
"azurerm_storage_account - support for the multichannel_enabled property (#17999)
azurerm_windows_virtual_machine - support for the gallery_application property (#18406)
azurerm_virtual_hub_bgp_connection - support for the virtual_network_connection_id property (#18469)
azurerm_windows_virtual_machine - support for the gallery_application property (#18406)"

[katbyte]

thanks @farwind for pointing that out - i've corrected the changelog

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.