azurerm_mssql_server_microsoft_support_auditing_policy - New resource

[aristosvo]

Fixes #18607

[katbyte]

Thanks @aristosvo - 1 small comment

[aristosvo]

Comment resolved!

[katbyte]

Looks like you missed a couple properties in the tests:

[aristosvo]

Forgotten test cases

[aristosvo]

Docs updates

[aristosvo]

Looks like you missed a couple properties in the tests:

@katbyte Thanks, I must've been sleeping!!😴 I'll blame my son for this who keeps me up at night 😅

[aristosvo]

Docs fix

[katbyte]

Thanks @aristosvo - i think the exist test function needs to account for case:

------- Stdout: -------
=== RUN   TestAccMsSqlServerMicrosoftSupportAuditingPolicy_requiresImport
=== PAUSE TestAccMsSqlServerMicrosoftSupportAuditingPolicy_requiresImport
=== CONT  TestAccMsSqlServerMicrosoftSupportAuditingPolicy_requiresImport
    testcase.go:110: Step 1/2 error: Check failed: Check 1/1 error: running exists func for "azurerm_mssql_server_microsoft_support_auditing_policy.test": ID was missing the `extendedAuditingSettings` element
--- FAIL: TestAccMsSqlServerMicrosoftSupportAuditingPolicy_requiresImport (320.82s)
FAIL

and a typo fixed:

------- Stdout: -------
=== RUN   TestAccMsSqlServerMicrosoftSupportAuditingPolicy_complete
=== PAUSE TestAccMsSqlServerMicrosoftSupportAuditingPolicy_complete
=== CONT  TestAccMsSqlServerMicrosoftSupportAuditingPolicy_complete
    testcase.go:110: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 34, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          34:   storage_account_access_key_is_secondary = false
        
        An argument named "storage_account_access_key_is_secondary" is not expected
        here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 35, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          35:   retention_in_days                       = 6
        
        An argument named "retention_in_days" is not expected here.
--- FAIL: TestAccMsSqlServerMicrosoftSupportAuditingPolicy_complete (7.84s)
FAIL

then this should be good!

[katbyte]

still getting a test failure 🤔

------- Stdout: -------
=== RUN   TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update
=== PAUSE TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update
=== CONT  TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update
    testcase.go:110: Step 7/8 error: Error running pre-apply refresh: exit status 1
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 42, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          42:   storage_account_access_key_is_secondary = true
        
        An argument named "storage_account_access_key_is_secondary" is not expected
        here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 43, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          43:   retention_in_days                       = 3
        
        An argument named "retention_in_days" is not expected here.
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 42, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          42:   storage_account_access_key_is_secondary = true
        
        An argument named "storage_account_access_key_is_secondary" is not expected
        here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 43, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          43:   retention_in_days                       = 3
        
        An argument named "retention_in_days" is not expected here.
--- FAIL: TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update (533.36s)
FAIL

[aristosvo]

still getting a test failure 🤔

------- Stdout: -------
=== RUN   TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update
=== PAUSE TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update
=== CONT  TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update
    testcase.go:110: Step 7/8 error: Error running pre-apply refresh: exit status 1
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 42, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          42:   storage_account_access_key_is_secondary = true
        
        An argument named "storage_account_access_key_is_secondary" is not expected
        here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 43, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          43:   retention_in_days                       = 3
        
        An argument named "retention_in_days" is not expected here.
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 42, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          42:   storage_account_access_key_is_secondary = true
        
        An argument named "storage_account_access_key_is_secondary" is not expected
        here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 43, in resource "azurerm_mssql_server_microsoft_support_auditing_policy" "test":
          43:   retention_in_days                       = 3
        
        An argument named "retention_in_days" is not expected here.
--- FAIL: TestAccMsSqlServerMicrosoftSupportAuditingPolicy_update (533.36s)
FAIL

Sorry, that's a bit sloppy. Fixed!

[katbyte]

Looks good now! thanks @aristosvo

[github-actions]

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.