Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_function_app, azurerm_linux_function_app: remove hasChange condition during creation #18680

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Oct 10, 2022

if the property is not set when sending the request during creation, the 32 bit worker is enabled, even the value is set to false by user

fix #18228

@GurliGebis
Copy link

Isn't this also the case for the normal app services as well?
Most likely they should be changed as well

@xiaxyi
Copy link
Contributor Author

xiaxyi commented Oct 13, 2022

@GurliGebis, do you mind be more specific about the normal app service? are you referring to azurerm_app_service resource provider?

@GurliGebis
Copy link

The two azurerm_linux_web_app and azurerm_windows_web_app.

I haven't teste them in a while, but I seem to remember them insisting on using 32bit when being created.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaxyi - LGTM 👍

@jackofallops jackofallops merged commit 27160da into hashicorp:main Oct 18, 2022
@github-actions github-actions bot added this to the v3.28.0 milestone Oct 18, 2022
jackofallops added a commit that referenced this pull request Oct 18, 2022
@github-actions
Copy link

This functionality has been released in v3.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function app "use_32_bit_worker" set to false not creating 64 bit platform with first attempt
3 participants