Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_integration_runtime_azure_ssis - support Elastic Pool #18696

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Oct 11, 2022

fix #18079

test

TF_ACC=1 go test -v ./internal/services/datafactory -run=TestAccDataFactoryIntegrationRuntimeManagedSsis_basic 
=== RUN   TestAccDataFactoryIntegrationRuntimeManagedSsis_basic
=== PAUSE TestAccDataFactoryIntegrationRuntimeManagedSsis_basic
=== CONT  TestAccDataFactoryIntegrationRuntimeManagedSsis_basic
--- PASS: TestAccDataFactoryIntegrationRuntimeManagedSsis_basic (255.56s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/datafactory   256.664s

TF_ACC=1 go test -v ./internal/services/datafactory -run=TestAccDataFactoryIntegrationRuntimeManagedSsis_withElasticPool    
=== RUN   TestAccDataFactoryIntegrationRuntimeManagedSsis_withElasticPool
=== PAUSE TestAccDataFactoryIntegrationRuntimeManagedSsis_withElasticPool
=== CONT  TestAccDataFactoryIntegrationRuntimeManagedSsis_withElasticPool
--- PASS: TestAccDataFactoryIntegrationRuntimeManagedSsis_withElasticPool (423.17s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/datafactory   424.286s

Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

@ziyeqf ziyeqf force-pushed the tengzh/issue/ssis_sql_pool branch from c73dbb2 to c809666 Compare October 11, 2022 09:26
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏷️

@katbyte katbyte merged commit d0e2244 into hashicorp:main Oct 12, 2022
@github-actions github-actions bot added this to the v3.27.0 milestone Oct 12, 2022
katbyte added a commit that referenced this pull request Oct 12, 2022
@ziyeqf ziyeqf deleted the tengzh/issue/ssis_sql_pool branch October 13, 2022 01:05
@github-actions
Copy link

This functionality has been released in v3.27.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants