Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_[linux|windows]_function_app and azurerm_[linux|windows]_function_app_slot fix app_settings diff when vnet_route_all_enabled = true #18836

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

jackofallops
Copy link
Member

*azurerm_linux_function_app - fix an issue where app_settings would show a diff when setting vnet_route_all_enabled to true
*azurerm_linux_function_app_slot - fix an issue where app_settings would show a diff when setting vnet_route_all_enabled to true
*azurerm_windows_function_app - fix an issue where app_settings would show a diff when setting vnet_route_all_enabled to true
*azurerm_windows_function_app_slot - fix an issue where app_settings would show a diff when setting vnet_route_all_enabled to true

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops
Copy link
Member Author

Tests look good.

@jackofallops jackofallops merged commit 37bf035 into main Oct 18, 2022
@jackofallops jackofallops deleted the b/functionapps-vnet-route-all-appsetting branch October 18, 2022 13:54
@github-actions github-actions bot added this to the v3.28.0 milestone Oct 18, 2022
jackofallops added a commit that referenced this pull request Oct 18, 2022
@github-actions
Copy link

This functionality has been released in v3.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants