Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource: azurerm_private_dns_resolver_outbound_endpoint #18986

Merged
merged 6 commits into from
Oct 27, 2022
Merged

new resource: azurerm_private_dns_resolver_outbound_endpoint #18986

merged 6 commits into from
Oct 27, 2022

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu
Copy link
Contributor Author

Hi @katbyte - Thanks for the code review. I've updated the docs and resolved the conflicts, please take another look, thanks!

@ms-henglu ms-henglu requested a review from stephybun October 27, 2022 05:46
stephybun
stephybun approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 💯

@stephybun stephybun merged commit b4dcd3a into hashicorp:main Oct 27, 2022
stephybun added a commit that referenced this pull request Oct 27, 2022
@stephybun
Update for #18986
1933a71
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 27, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte requested changes

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/private-dns-resolver
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-henglu @katbyte @stephybun