-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster
- support for the azure_monitor_kubernetes_metrics
property
#19530
azurerm_kubernetes_cluster
- support for the azure_monitor_kubernetes_metrics
property
#19530
Conversation
ms-henglu
commented
Dec 2, 2022
azurerm_kubernetes_cluster
- azure_monitor_profile
azurerm_kubernetes_cluster
- support for the azure_monitor_profile
property
Hi @tombuildsstuff - Thanks for the code review. I've updated this PR as suggested. Please take another look, thanks! |
azurerm_kubernetes_cluster
- support for the azure_monitor_profile
propertyazurerm_kubernetes_cluster
- support for the azure_monitor_kubernetes_metrics
property
1f776a9
to
537aca8
Compare
"azure_monitor_kubernetes_metrics": { | ||
Type: pluginsdk.TypeList, | ||
MaxItems: 1, | ||
Optional: true, | ||
Elem: &pluginsdk.Resource{ | ||
Schema: map[string]*pluginsdk.Schema{ | ||
"metric_annotations_allow_list": { | ||
Type: pluginsdk.TypeString, | ||
Optional: true, | ||
ValidateFunc: validation.StringIsNotEmpty, | ||
}, | ||
|
||
"metric_labels_allow_list": { | ||
Type: pluginsdk.TypeString, | ||
Optional: true, | ||
ValidateFunc: validation.StringIsNotEmpty, | ||
}, | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
azure and kubernetes seem redundant here, perhaps this would be sufficient
"azure_monitor_kubernetes_metrics": { | |
Type: pluginsdk.TypeList, | |
MaxItems: 1, | |
Optional: true, | |
Elem: &pluginsdk.Resource{ | |
Schema: map[string]*pluginsdk.Schema{ | |
"metric_annotations_allow_list": { | |
Type: pluginsdk.TypeString, | |
Optional: true, | |
ValidateFunc: validation.StringIsNotEmpty, | |
}, | |
"metric_labels_allow_list": { | |
Type: pluginsdk.TypeString, | |
Optional: true, | |
ValidateFunc: validation.StringIsNotEmpty, | |
}, | |
}, | |
}, | |
}, | |
"monitor_metrics": { | |
Type: pluginsdk.TypeList, | |
MaxItems: 1, | |
Optional: true, | |
Elem: &pluginsdk.Resource{ | |
Schema: map[string]*pluginsdk.Schema{ | |
"annotations_allowed": { | |
Type: pluginsdk.TypeString, | |
Optional: true, | |
ValidateFunc: validation.StringIsNotEmpty, | |
}, | |
"labels_allowed": { | |
Type: pluginsdk.TypeString, | |
Optional: true, | |
ValidateFunc: validation.StringIsNotEmpty, | |
}, | |
}, | |
}, | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu LGTM 👍
…tes_metrics` property (hashicorp#19530) * `azurerm_kubernetes_cluster` - `azure_monitor_profile` * change schema * fmt * rename fields * fix minor issues in docs Co-authored-by: Steph <steph@hashicorp.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |