Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade postgresql server API version from 2022-03-08-preview to 2022-12-01 #20073

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jan 18, 2023

image

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neil-yechenwei
Thanks for this PR. It looks mostly fine, just one issue to look into below. I know @ziyeqf from your team is also working on this resource, so you may need to co-ordinate there for rebasing depending on who's changes are merged first.

Thanks!

@ziyeqf
Copy link
Contributor

ziyeqf commented Jan 19, 2023

Hi @neil-yechenwei Thanks for this PR. It looks mostly fine, just one issue to look into below. I know @ziyeqf from your team is also working on this resource, so you may need to co-ordinate there for rebasing depending on who's changes are merged first.

Thanks!

Hi @jackofallops , please review/merge this PR first, thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦑

@katbyte katbyte merged commit 1ea4396 into hashicorp:main Jan 20, 2023
@github-actions github-actions bot added this to the v3.41.0 milestone Jan 20, 2023
katbyte added a commit that referenced this pull request Jan 20, 2023
@github-actions
Copy link

This functionality has been released in v3.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants