Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource azurerm_network_manager_static_member #20077

Merged
merged 3 commits into from
Jan 19, 2023
Merged

New Resource azurerm_network_manager_static_member #20077

merged 3 commits into from
Jan 19, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Jan 18, 2023

jackofallops
jackofallops requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new resource @teowa
I think this looks mostly good, just a few comments below, then we can take another look.

Thanks!

internal/services/network/network_manager_static_member_resource.go Outdated Show resolved Hide resolved
internal/services/network/network_manager_static_member_resource.go Outdated Show resolved Hide resolved
internal/services/network/network_manager_static_member_resource.go Outdated Show resolved Hide resolved
internal/services/network/network_manager_static_member_resource_test.go Outdated Show resolved Hide resolved
@teowa
Copy link
Contributor Author

teowa commented Jan 18, 2023

Hi @jackofallops , thanks for reviewing this.
I have changed the code, please take another look.

katbyte
katbyte approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍵

@katbyte katbyte merged commit f9d531d into hashicorp:main Jan 19, 2023
katbyte added a commit that referenced this pull request Jan 19, 2023
@katbyte
CHANGELOG #20077
f55b74f
@github-actions github-actions bot added this to the v3.40.0 milestone Jan 19, 2023
@github-actions
Copy link

This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@teowa teowa mentioned this pull request Jan 20, 2023
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/network size/XL
Projects
None yet
Milestone
v3.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@teowa @katbyte @jackofallops