Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Recover Services Vaults feature request #20080

Closed
1 task done
Mofato opened this issue Jan 18, 2023 · 3 comments · Fixed by #21691
Closed
1 task done

Azure Recover Services Vaults feature request #20080

Mofato opened this issue Jan 18, 2023 · 3 comments · Fixed by #21691

Comments

@Mofato
Copy link

Mofato commented Jan 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently we are deploying Recovery Services Vault with terraform on Microsoft Azure. But we cannot set the Monitoring Settings with terraform provider azurerm. The monitor settings can be set with api version 22-10-01. See the json code below.
"monitoringSettings": {
"azureMonitorAlertSettings": {
"alertsForAllJobFailures": "Enabled"
},
"classicAlertSettings": {
"alertsForCriticalOperations": "Disabled"
}
},
Second we also want to set the Public Network Access which also is available in api version 22-10-01. See the json code below.
"publicNetworkAccess": "Disabled"

image

New or Affected Resource(s)/Data Source(s)

azurerm_recovery_services_vault

Potential Terraform Configuration

resource "azurerm_recovery_services_vault" "recovery_services_vault" {
  name                      = "RSV"
  location                  = "westeurope"
  resource_group_name       = "RG_RSV"

  sku                       = "Standard"
  soft_delete_enabled       = true
  storage_mode_type         = "GeoRedundant"
  
  tags = local.tags

  identity {
    type                    = "SystemAssigned"
  }

      monitoringSettings = {
        azureMonitorAlertSettings = {
          alertsForAllJobFailures = "Enabled"
        }
        classicAlertSettings = {
          alertsForCriticalOperations = "Disabled"
        }
      }

      publicNetworkAccess = "Disabled"
}

References

No response

@ziyeqf
Copy link
Contributor

ziyeqf commented May 8, 2023

Hi @Mofato, thanks for reporting.

I have submitted a PR (#21691) to add support for this feature. You can subscribe it to keep track.

For any further questions please leave comments.
Thanks!

@github-actions github-actions bot added this to the v3.57.0 milestone May 17, 2023
@github-actions
Copy link

This functionality has been released in v3.57.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants