Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_media_streaming_policy - support for more features #20524

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Feb 17, 2023

Support for:

  • common_encryption_cbcs.clear_key_encryption_configuration
  • common_encryption_cenc.clear_key_encryption_configuration
  • common_encryption_cenc.clear_track
  • common_encryption_cenc.content_key_to_track_mapping
  • envelope_encryption

Reference:

Test:

make acctests SERVICE="media" TESTARGS="-parallel 20 -test.run=TestAccStreamingPolicy_" TESTTIMEOUT='1440m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/media -parallel 20 -test.run=TestAccStreamingPolicy_ -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStreamingPolicy_basic
=== PAUSE TestAccStreamingPolicy_basic
=== RUN   TestAccStreamingPolicy_clearKeyEncryption
=== PAUSE TestAccStreamingPolicy_clearKeyEncryption
=== RUN   TestAccStreamingPolicy_requiresImport
=== PAUSE TestAccStreamingPolicy_requiresImport
=== RUN   TestAccStreamingPolicy_complete
=== PAUSE TestAccStreamingPolicy_complete
=== RUN   TestAccStreamingPolicy_update
=== PAUSE TestAccStreamingPolicy_update
=== CONT  TestAccStreamingPolicy_basic
=== CONT  TestAccStreamingPolicy_complete
=== CONT  TestAccStreamingPolicy_requiresImport
=== CONT  TestAccStreamingPolicy_clearKeyEncryption
=== CONT  TestAccStreamingPolicy_update
--- PASS: TestAccStreamingPolicy_basic (133.83s)
--- PASS: TestAccStreamingPolicy_clearKeyEncryption (136.04s)
--- PASS: TestAccStreamingPolicy_requiresImport (137.51s)
--- PASS: TestAccStreamingPolicy_complete (198.46s)
--- PASS: TestAccStreamingPolicy_update (227.08s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/media 228.374s

@teowa teowa changed the title azurerm_media_streaming_policy - support for more feature azurerm_media_streaming_policy - support for more features Feb 20, 2023
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @teowa, the docs needs a few adjustments as well as the schema. Otherwise this is looking good.

website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
internal/services/media/media_streaming_policy_resource.go Outdated Show resolved Hide resolved
internal/services/media/media_streaming_policy_resource.go Outdated Show resolved Hide resolved
@teowa
Copy link
Contributor Author

teowa commented Feb 24, 2023

Hi @stephybun , thanks for reviewing.
I have changed the code per review comment, please kindly have another look.

TF_ACC=1 go test -v ./internal/services/media -parallel 20 -test.run=TestAccStreamingPolicy_ -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStreamingPolicy_basic
=== PAUSE TestAccStreamingPolicy_basic
=== RUN   TestAccStreamingPolicy_clearKeyEncryption
=== PAUSE TestAccStreamingPolicy_clearKeyEncryption
=== RUN   TestAccStreamingPolicy_requiresImport
=== PAUSE TestAccStreamingPolicy_requiresImport
=== RUN   TestAccStreamingPolicy_complete
=== PAUSE TestAccStreamingPolicy_complete
=== RUN   TestAccStreamingPolicy_update
=== PAUSE TestAccStreamingPolicy_update
=== CONT  TestAccStreamingPolicy_basic
=== CONT  TestAccStreamingPolicy_complete
=== CONT  TestAccStreamingPolicy_requiresImport
=== CONT  TestAccStreamingPolicy_clearKeyEncryption
=== CONT  TestAccStreamingPolicy_update
--- PASS: TestAccStreamingPolicy_basic (131.54s)
--- PASS: TestAccStreamingPolicy_complete (131.57s)
--- PASS: TestAccStreamingPolicy_requiresImport (132.65s)
--- PASS: TestAccStreamingPolicy_clearKeyEncryption (193.25s)
--- PASS: TestAccStreamingPolicy_update (208.67s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/media 210.662s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa LGTM 🦢

@stephybun stephybun merged commit 80086a1 into hashicorp:main Feb 24, 2023
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 24, 2023
stephybun added a commit that referenced this pull request Feb 24, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants