Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_function_app and azurerm_windows_function_app support for zip_deploy_file #20544

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

x-delfino
Copy link
Contributor

PR to add zip_deploy_file to azurerm_linux_function_app and azure_rm_windows_function_app. These changes are based on the existing capabilities available for Web apps so pretty much no new code. I've updated the docs including a small change for the environment variables required for zip deployment both for function apps and web apps.

Tests:

make acctests SERVICE='appservice' TESTARGS='-run=TestAccLinuxFunctionApp_zipDeploy' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxFunctionApp_zipDeploy -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxFunctionApp_zipDeploy
=== PAUSE TestAccLinuxFunctionApp_zipDeploy
=== CONT  TestAccLinuxFunctionApp_zipDeploy
--- PASS: TestAccLinuxFunctionApp_zipDeploy (514.32s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    514.408s
make acctests SERVICE='appservice' TESTARGS='-run=TestAccWindowsFunctionApp_zipDeploy' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccWindowsFunctionApp_zipDeploy -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWindowsFunctionApp_zipDeploy
=== PAUSE TestAccWindowsFunctionApp_zipDeploy
=== CONT  TestAccWindowsFunctionApp_zipDeploy
--- PASS: TestAccWindowsFunctionApp_zipDeploy (484.42s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    484.518s

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @x-delfino - This LGTM 👍

@jackofallops
Copy link
Member

Tests look good - Failures are unrelated to the change

image

@jackofallops jackofallops merged commit af65719 into hashicorp:main Mar 24, 2023
@github-actions github-actions bot added this to the v3.50.0 milestone Mar 24, 2023
jackofallops added a commit that referenced this pull request Mar 24, 2023
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants