Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_backup_protected_vm: support protection_state #20608

Merged
merged 12 commits into from
Jun 13, 2023
Merged

azurerm_backup_protected_vm: support protection_state #20608

merged 12 commits into from
Jun 13, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Feb 22, 2023 •
edited
Loading

close #20571

Screenshot 2023-02-22 at 19 23 17

@ziyeqf ziyeqf mentioned this pull request Feb 22, 2023
Closed
1 task
@ziyeqf ziyeqf force-pushed the tengzh/issue/backup_vm_retain branch from ce80e45 to 3b47d0f Compare February 22, 2023 10:14
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Feb 22, 2023

tmp close to wait for test result

@ziyeqf ziyeqf closed this Feb 22, 2023
@ziyeqf ziyeqf reopened this Feb 22, 2023
@ziyeqf ziyeqf marked this pull request as ready for review February 22, 2023 11:23
tombuildsstuff
tombuildsstuff suggested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ziyeqf

Thanks for this PR - I've taken a look through and left some comments inline, if we can fix those up then we should be able to take another look and get this merged 👍

Thanks!

internal/services/recoveryservices/backup_protected_vm_resource.go Outdated Show resolved Hide resolved
internal/services/recoveryservices/backup_protected_vm_resource.go Outdated Show resolved Hide resolved
internal/services/recoveryservices/backup_protected_vm_resource.go Outdated Show resolved Hide resolved
internal/services/recoveryservices/backup_protected_vm_resource.go Outdated Show resolved Hide resolved
internal/services/recoveryservices/backup_protected_vm_resource.go Outdated Show resolved Hide resolved
internal/services/recoveryservices/backup_protected_vm_resource.go Outdated Show resolved Hide resolved
website/docs/r/backup_protected_vm.html.markdown Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/L and removed size/M labels Feb 23, 2023
@ziyeqf ziyeqf changed the title azurerm_backup_protected_vm: support protection_stopped azurerm_backup_protected_vm: support protection_state Apr 14, 2023
@ziyeqf ziyeqf force-pushed the tengzh/issue/backup_vm_retain branch from ac1e49b to c3aabfc Compare April 14, 2023 02:51
@github-actions github-actions bot added size/M and removed size/L labels Apr 14, 2023
@ziyeqf
remove duplicate codes
db3ddef 
Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>
@stephybun
Copy link
Member

@ziyeqf any updates?

@avooca
Copy link

avooca commented Jun 12, 2023

@ziyeqf any updates?

AFAIK there shouldnt be a codechange required, this was fixed at the API level by MS.

ziyeqf added 2 commits June 13, 2023 10:50
@ziyeqf
Merge branch 'main' into tengzh/issue/backup_vm_retain
7f2862a
@ziyeqf
update code
e4f4614 
Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Jun 13, 2023 •
edited
Loading

I have triggered a test on TC and will update the result here.

@ziyeqf
golint
6b95518 
Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Jun 13, 2023

Screenshot 2023-06-13 at 12 21 52

katbyte
katbyte approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ziyeqf - LGTM 💾

@katbyte katbyte merged commit 1ed1fed into hashicorp:main Jun 13, 2023
katbyte added a commit that referenced this pull request Jun 13, 2023
@katbyte
Update CHANGELOG.md #20608
a95f830
@github-actions github-actions bot added this to the v3.61.0 milestone Jun 13, 2023
@ziyeqf ziyeqf deleted the tengzh/issue/backup_vm_retain branch June 13, 2023 09:01
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/recovery-services size/M
Projects
None yet
Milestone
v3.61.0
Development

Successfully merging this pull request may close these issues.

Support for retain vm backup when deleting azurerm_backup_protected_vm resource
5 participants
@ziyeqf @stephybun @avooca @tombuildsstuff @katbyte