Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_express_route_connection - Support inbound_route_map_id, outbound_route_map_id, enabled_private_link_fast_path #20619

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

xuzhang3
Copy link
Contributor

Support inbound_route_map_id, outbound_route_map_id, enabled_private_link_fast_path

=== RUN   TestAccExpressRouteConnection_basic
--- PASS: TestAccExpressRouteConnection_basic (5665.34s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       5705.892s


PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       6358.210s

=== RUN   TestAccExpressRouteConnection
=== RUN   TestAccExpressRouteConnection/Resource
=== RUN   TestAccExpressRouteConnection/Resource/requiresImport
--- PASS: TestAccExpressRouteConnection (5550.84s)
    --- PASS: TestAccExpressRouteConnection/Resource (5550.84s)
        --- PASS: TestAccExpressRouteConnection/Resource/requiresImport (5550.84s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       5603.748s

=== RUN   TestAccExpressRouteConnection
=== RUN   TestAccExpressRouteConnection/Resource
=== RUN   TestAccExpressRouteConnection/Resource/complete
--- PASS: TestAccExpressRouteConnection (5472.03s)
    --- PASS: TestAccExpressRouteConnection/Resource (5472.03s)
        --- PASS: TestAccExpressRouteConnection/Resource/complete (5472.03s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       5532.557s

=== RUN   TestAccExpressRouteConnection
=== RUN   TestAccExpressRouteConnection/Resource
=== RUN   TestAccExpressRouteConnection/Resource/update
--- PASS: TestAccExpressRouteConnection (6486.12s)
    --- PASS: TestAccExpressRouteConnection/Resource (6486.12s)
        --- PASS: TestAccExpressRouteConnection/Resource/update (6486.12s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       6533.837s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @xuzhang3, left a few comments in-line but once those are resolved we can take another look and get this merged!

website/docs/r/express_route_connection.html.markdown Outdated Show resolved Hide resolved
website/docs/r/express_route_connection.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@katbyte katbyte merged commit 39606bd into hashicorp:main Feb 23, 2023
katbyte added a commit that referenced this pull request Feb 23, 2023
@github-actions github-actions bot added this to the v3.45.0 milestone Feb 23, 2023
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzhang3 LGTM 🚴

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
@xuzhang3 xuzhang3 deleted the f/er_connection_enhacne branch August 14, 2024 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants