Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sentinel_log_analytics_workspace_onboarding: support workspace_id, deprecate resource_group_name and workspace_name #20661

Merged
merged 8 commits into from
Mar 20, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Feb 27, 2023

Screenshot 2023-02-27 at 14 42 12

the failed ones are because of `InvalidLicense`

Acctests may fail with is not onboarded

Error: checking for presence of existing Data Connector: (Name "accTestDC-230224022526508153" / Workspace Name "acctestLAW-230224022526508153" / Resource Group "acctestRG-sentinel-230224022526508153"): securityinsight.DataConnectorsClient#Get: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="{\"error\":{\"code\":\"BadRequest\",\"message\":\"Workspace 'acctestLAW-230224022526508153' is not onboarded to Microsoft Sentinel.\"}}"

change from azurerm_log_analytics_solution to azurerm_sentinel_log_analytics_workspace_onboarding.

azurerm_sentinel_alert_rule_fusion is excluded, the service is installing Advanced Multistage Attack Detection by default in onboarding API, the only one fusion rule. It's also installed by default by Portal. May update its test case in another PR

@ziyeqf ziyeqf marked this pull request as ready for review February 27, 2023 06:42
…pace_id`, deprecate `resource_group_name` and `workspace_name`
@github-actions
Copy link

Build failure

Found new usages of deprecated functionality:

https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/4288985626

@github-actions
Copy link

Build failure

Found new usages of deprecated functionality:

https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/4289101196

@github-actions
Copy link

Build failure

Found new usages of deprecated functionality:

https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/4289695954

@github-actions
Copy link

Build failure

Found new usages of deprecated functionality:

https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/4289760979

@ziyeqf ziyeqf changed the title Sentinel: improve acctests, update docs. azurerm_sentinel_log_analytics_workspace_onboarding: support workspace_id, deprecate resource_group_name and workspace_name Feb 28, 2023
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Feb 28, 2023

Screenshot 2023-02-28 at 18 50 36

the failed ones are because of `InvalidLicense`.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👽

@katbyte katbyte merged commit 126e0e1 into hashicorp:main Mar 20, 2023
@github-actions github-actions bot added this to the v3.49.0 milestone Mar 20, 2023
katbyte added a commit that referenced this pull request Mar 20, 2023
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants