Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

express_route_circuit_peering_resource - Support advertised_communities #20708

Merged
merged 1 commit into from
Mar 2, 2023
Merged

express_route_circuit_peering_resource - Support advertised_communities #20708

merged 1 commit into from
Mar 2, 2023

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented Mar 1, 2023

  1. Support advertised_communities
  2. Fix potential bug: Update may remove the connections created on this peering.
=== RUN   TestAccExpressRouteCircuit
=== RUN   TestAccExpressRouteCircuit/MicrosoftPeering
=== RUN   TestAccExpressRouteCircuit/MicrosoftPeering/microsoftPeering
=== RUN   TestAccExpressRouteCircuit/MicrosoftPeering/microsoftPeeringIpv6
--- PASS: TestAccExpressRouteCircuit (1310.67s)
    --- PASS: TestAccExpressRouteCircuit/MicrosoftPeering (1310.67s)
        --- PASS: TestAccExpressRouteCircuit/MicrosoftPeering/microsoftPeering (592.86s)
        --- PASS: TestAccExpressRouteCircuit/MicrosoftPeering/microsoftPeeringIpv6 (717.82s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       5651.990s

katbyte
katbyte approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☄️

@katbyte katbyte merged commit e1f27ff into hashicorp:main Mar 2, 2023
@github-actions github-actions bot added this to the v3.46.0 milestone Mar 2, 2023
katbyte added a commit that referenced this pull request Mar 2, 2023
@katbyte
CHANGELOG #20708
e0bea8c
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This functionality has been released in v3.46.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
@xuzhang3 xuzhang3 deleted the enhance/er_circuit_connection branch August 14, 2024 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/network size/S
Projects
None yet
Milestone
v3.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xuzhang3 @katbyte