-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_mysql_flexible_server
- support geo_backup_key_vault_key_id
and geo_backup_user_assigned_identity_id
#20796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures:
------- Stdout: -------
=== RUN TestAccMySqlFlexibleServer_complete
=== PAUSE TestAccMySqlFlexibleServer_complete
=== CONT TestAccMySqlFlexibleServer_complete
testcase.go:110: Step 1/2 error: Error running apply: exit status 1
Error: creating Flexible Server (Subscription: "*******"
Resource Group Name: "acctestRG-mysql-230307035443686329"
Flexible Server Name: "acctest-fs-230307035443686329"): polling after Create: Code="InternalServerError" Message="An unexpected error occured while processing the request. Tracking ID: '60d8c15a-3b56-48bd-9726-18b7f576fa67'"
with azurerm_mysql_flexible_server.test,
on terraform_plugin_test.tf line 63, in resource "azurerm_mysql_flexible_server" "test":
63: resource "azurerm_mysql_flexible_server" "test" {
--- FAIL: TestAccMySqlFlexibleServer_complete (544.95s)
FAIL
@katbyte , maybe it's quota issue, so I changed the test location for mysql in settings.kt in this PR. Hence, maybe you also have to change the test location before PR merge. I just now reran the test cases. Seems they all passed. |
@neil-yechenwei - if the wrong location is picked if that is so could you please open an issue on the rest specs detailing it, and adding a note in the documentation as that is a very hard to action/understand error |
@katbyte , raised an issue on azure rest api spec. Actually, the test case you above mentioned has failed with same error message for a long time in Teamcity. It's not related with this PR. I assume we don't need to add a note in the doc for now because I've talked with service team offline and they confirmed they would fix it asap. |
@katbyte , Seems the quota issue is resolved on your test subs. So I reverted the change about test location. I just now reran test cases and all passed. |
@katbyte , as test cases passed, is it fine to be merged for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM aside from 1 comment
This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fixes #20408
To enable
geo_redundant_backup_enabled
, these two propertiesgeo_backup_key_vault_key_id
andgeo_backup_user_assigned_identity_id
also need to be set.