Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Resources: Add missing empty-id logic when resource was not found during read #20797

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Mar 6, 2023

Some resources are missing the logic of d.SetId("")/metadata.MarkAsGone(id) in read when resource is not found, which could cause the issue that a resource cannot be recreated when deleted outside Terraform. Adding the missing ones.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @myc2h6o

@mbfrahry mbfrahry added this to the v3.47.0 milestone Mar 6, 2023
@mbfrahry mbfrahry changed the title Add missing empty-id logic in read Various Resources: Add missing empty-id logic when resource was not found during read Mar 6, 2023
@mbfrahry mbfrahry merged commit f405d58 into hashicorp:main Mar 6, 2023
@myc2h6o myc2h6o deleted the read_nil_id branch March 7, 2023 02:52
tombuildsstuff added a commit that referenced this pull request Mar 7, 2023
jackofallops pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants