Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_bot_channel_directline - initiate site to empty list #20890

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Mar 10, 2023

fixes #20892

Recently "TestAccBotChannelsRegistration/channel/directlineBasic", "TestAccBotChannelsRegistration/channel/directlineUpdate" and "TestAccBotChannelsRegistration/channel/directlineComplete" are failed in Teamcity. After investigated, I found TF would always assign an empty block to site while initiating. And now service team updated the validation logic to restrict service API to not accept empty block for site so that these test cases failed.

    --- PASS: TestAccBotChannelsRegistration/channel/directlineBasic (274.67s)
    --- PASS: TestAccBotChannelsRegistration/channel/directlineComplete (267.46s)
    --- PASS: TestAccBotChannelsRegistration/channel/directlineUpdate (499.90s)

@github-actions github-actions bot added size/M and removed size/XS labels Mar 10, 2023
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @neil-yechenwei

@tombuildsstuff tombuildsstuff added this to the v3.48.0 milestone Mar 14, 2023
@tombuildsstuff tombuildsstuff merged commit 78a1510 into hashicorp:main Mar 14, 2023
tombuildsstuff added a commit that referenced this pull request Mar 14, 2023
@github-actions
Copy link

This functionality has been released in v3.48.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to create azurerm_bot_channel_directline
2 participants