Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - Deprecate network_profile.docker_bridge_cidr since it's not longer supported by API #20952

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

lonegunmanb
Copy link
Contributor

@lonegunmanb lonegunmanb commented Mar 15, 2023

According to the document:

Docker is no longer supported as of September 2022.

This pr loose the original restriction: ``docker_bridge_cidr, dns_service_ip` and `service_cidr` should all be empty or all should be set"`, now we can just omit `docker_bridge_cidr`.

This pr should fix #18119 and this aks module issue


I've also received an email said:

We've detected that one or more of your subscription(s) are using the Docker Bridge CIDR field in the AKS API. This field is currently ignored by default and not validated, as it was made redundant during our change from Docker to containerD in Kubernetes version 1.19. Starting from April 2023 with the release of the 2023-04-01 AKS API version, the Docker Bridge CIDR field functionality will be removed. However, it will still be supported in all preexisting API versions without new updates. The April API will be fully implemented and available by 26 May 2023.

@lonegunmanb lonegunmanb changed the title azurerm_kubernetes_- Enable setting service_cidr and dns_service_ip without setting docker_bridge_cidr` azurerm_kubernetes_cluster - Enable setting service_cidr and dns_service_ip without setting docker_bridge_cidr Mar 15, 2023
@catriona-m catriona-m requested a review from stephybun March 15, 2023 09:54
@lonegunmanb lonegunmanb changed the title azurerm_kubernetes_cluster - Enable setting service_cidr and dns_service_ip without setting docker_bridge_cidr azurerm_kubernetes_cluster - Deprecate network_profile.docker_bridge_cidr since it's not longer supported by API Mar 15, 2023
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonegunmanb LGTM 🍉

@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_kubernetes_cluster: remove unused docker_bridge_cidr variable
2 participants