Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_ssh_public_key - allow . for name validation #20955

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Mar 15, 2023

After checking, the name of azurerm_ssh_public_key is allowed to contain dots. So submit this PR to fix #20920.

Test Result:
PASS: TestAccDataSourceAzureSshPublicKey_basic (197.07s)

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title azurerm_ssh_public_key - fix name validation for resource azurerm_ssh_public_key azurerm_ssh_public_key - allow . for name validation Mar 15, 2023
@mbfrahry mbfrahry merged commit 8426e3f into hashicorp:main Mar 15, 2023
mbfrahry added a commit that referenced this pull request Mar 15, 2023
@github-actions
Copy link

This functionality has been released in v3.48.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sinbai sinbai deleted the compute/fix_name_validation branch March 17, 2023 01:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_ssh_public_key name validation incorrectly rejects period
2 participants