Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource : azurerm_storage_mover #21000

Merged

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Mar 17, 2023

Swagger Link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/storagemover/resource-manager/Microsoft.StorageMover/stable/2023-03-01/storagemover.json

Test Results:
PASS: TestAccStorageMover_basic (355.79s)
PASS: TestAccStorageMover_requiresImport (384.30s)
PASS: TestAccStorageMover_complete (371.36s)
PASS: TestAccStorageMover_update (606.43s)

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai, assuming the tests are good this LGTM

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinbai This service availability seems limited, please can you update the tests to use one of eastus, eastus2, westus3 or swedencentral instead of the default location?

@sinbai
Copy link
Contributor Author

sinbai commented Mar 20, 2023

@sinbai This service availability seems limited, please can you update the tests to use one of eastus, eastus2, westus3 or swedencentral instead of the default location?

@manicminer thanks for your feedback. The setting of Teamcity has been updated. Could you please take another look?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to register the RP?

Error: creating Storage Mover (Subscription: "*******"
        Resource Group Name: "acctest-rg-230321013753853492"
        Storage Mover Name: "acctest-ssm-230321013753853492"): unexpected status 409 with response: {"error":{"code":"MissingSubscriptionRegistration","message":"The subscription is not registered to use namespace 'Microsoft.StorageMover'. See https://aka.ms/rps-not-found for how to register subscriptions.","details":[{"code":"MissingSubscriptionRegistration","target":"Microsoft.StorageMover","message":"The subscription is not registered to use namespace 'Microsoft.StorageMover'. See https://aka.ms/rps-not-found for how to register subscriptions."}]}}

@sinbai
Copy link
Contributor Author

sinbai commented Mar 21, 2023

I think we need to register the RP?

Error: creating Storage Mover (Subscription: "*******"
        Resource Group Name: "acctest-rg-230321013753853492"
        Storage Mover Name: "acctest-ssm-230321013753853492"): unexpected status 409 with response: {"error":{"code":"MissingSubscriptionRegistration","message":"The subscription is not registered to use namespace 'Microsoft.StorageMover'. See https://aka.ms/rps-not-found for how to register subscriptions.","details":[{"code":"MissingSubscriptionRegistration","target":"Microsoft.StorageMover","message":"The subscription is not registered to use namespace 'Microsoft.StorageMover'. See https://aka.ms/rps-not-found for how to register subscriptions."}]}}

Yes. This is a new service. Could you please help to register Microsoft.StorageMover for the subscription used by Teamcity?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to the list of RPs to register in the resourceproviders package

@sinbai sinbai force-pushed the storagemover/new_resource_storagemover branch from c582345 to 493b31d Compare March 28, 2023 07:47
@sinbai sinbai force-pushed the storagemover/new_resource_storagemover branch from 1ebe61f to d20ff92 Compare March 28, 2023 07:57
@sinbai
Copy link
Contributor Author

sinbai commented Mar 28, 2023

Please add it to the list of RPs to register in the resourceproviders package

@katbyte Thanks for letting me know this. I have added it. Could you please take another look?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai - LGTM 🧮

@katbyte katbyte merged commit a69813b into hashicorp:main Apr 1, 2023
katbyte added a commit that referenced this pull request Apr 1, 2023
@github-actions github-actions bot added this to the v3.51.0 milestone Apr 1, 2023
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sinbai sinbai deleted the storagemover/new_resource_storagemover branch March 28, 2024 02:52
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants