Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_[linux|windows]_[function|web]_app[_slot] - Fix nilpointer auth_v2 #21113

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

aristosvo
Copy link
Collaborator

Fixes #21110

@aristosvo aristosvo requested a review from jackofallops March 24, 2023 07:21
@aristosvo aristosvo changed the title Fix nilpointer Fix nilpointer auth_v2 Mar 24, 2023
@aristosvo aristosvo changed the title Fix nilpointer auth_v2 azurerm_[linux|windows]_[function|web]_app[_slot] - Fix nilpointer auth_v2 Mar 24, 2023
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - Good spot, sorry I missed this!

@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ncook-hxgn
Copy link

I'm not sure this is fixed?
#20989 (comment)

@aristosvo
Copy link
Collaborator Author

aristosvo commented Apr 5, 2023

@ncook-hxgn See #21219, another nilpointer issue showed up, will be in next release!

@ncook-hxgn
Copy link

still broken :(
#20989 (comment)

@aristosvo
Copy link
Collaborator Author

@ncook-hxgn Did you check out v3.52.0?

@ncook-hxgn
Copy link

The good news: it no longer crashes with 3.52!
The bad news: #20989 is still broken. When I browse to the URL I now get:

AADSTS700054: response_type 'id_token' is not enabled for the application

Copy link

github-actions bot commented Jun 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform-provider-azurerm_v3.49.0_x5.exe plugin crashed
3 participants