refactor: replacing usages of azure.ValidateResourceID with more specific Resource ID Parsers
#21129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/api-management
service/application-insights
service/data-factory
service/data-share
service/database-migration
service/databricks
service/dns
service/event-grid
…it_id`, `peer_virtual_network_gateway_id` and `local_network_gateway_id`
…public_ip_prefix_id`
… since this shouldn't be used
…`public_ip_prefix_id`
…n to not parse d.Get
…ResourceIDOrEmpty` as deprecated soon
tombuildsstuff
force-pushed
the
refactor/gradually-deprecating-suppress-case-diff-and-validate-resource-id
branch
from
8567bf2 to
a1c1381
Compare
tombuildsstuff
deleted the
refactor/gradually-deprecating-suppress-case-diff-and-validate-resource-id
branch
tombuildsstuff
added a commit
that referenced
this pull request
Mar 27, 2023
|
This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Closed
1 task
1 task
This was referenced Mar 31, 2023
1 task
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works through the usages of
azure.ValidateResourceIDandazure.ValidateResourceIDOrEmptyand replaces these usages with the Resource ID parser we're expecting, where possible.This PR also then removes some superfluous usages of
suppress.CaseDifference- it also marksazure.ValidateResourceIDOrEmptyas deprecated (today) and calls out that the methodsazure.ValidateResourceIDandsuppress.CaseDifferencewill both be deprecated in the future.I've intentionally split each change out into it's own commit, since this'll help with the changelog entries.