Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_container_app - Support for both system and user assigned identities at the same time #21149

Merged
merged 4 commits into from
Jun 27, 2023
Merged

azurerm_container_app - Support for both system and user assigned identities at the same time #21149

merged 4 commits into from
Jun 27, 2023

Conversation

jkrilov
Copy link
Contributor

@jkrilov jkrilov commented Mar 27, 2023 •
edited by jackofallops
Loading

fixes #21148
fixes #20437

@jkrilov jkrilov mentioned this pull request Mar 27, 2023
Closed
1 task
@jkrilov jkrilov changed the title F/containerapp both identities azurerm_container_app - Allow both system and user assigned identities Mar 27, 2023
@jkrilov jkrilov changed the title azurerm_container_app - Allow both system and user assigned identities azurerm_container_app - Support for both system and user assigned identities at the same time Mar 27, 2023
@jkrilov jkrilov changed the title azurerm_container_app - Support for both system and user assigned identities at the same time azurerm_container_app - Support for both system and user assigned identities at the same time Mar 28, 2023
@jkrilov jkrilov marked this pull request as ready for review March 28, 2023 11:44
@jkrilov
Copy link
Contributor Author

jkrilov commented Apr 7, 2023

@jackofallops any update on this?

@jtatum
Copy link

jtatum commented May 19, 2023

Also fixes #20437

@jkrilov jkrilov mentioned this pull request May 19, 2023
Closed
1 task
@jkrilov
Copy link
Contributor Author

jkrilov commented May 19, 2023

@tombuildsstuff this has gone almost two months without an update. Is it possible to assign a new reviewer? This is a fairly small change.

@eugene-prout
Copy link

@jackofallops @tombuildsstuff Could this be reviewed please? It's causing me issues too and it looks ready to be merged. If not, could you suggest a workaround?

jackofallops
jackofallops approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Joey40, Thanks for this PR and apologies for the delay in getting to it.

This LGTM 👍

Thanks again!

@jackofallops
Copy link
Member

tests look good (failure was a transient service issue)

image

@jackofallops jackofallops merged commit 0e3edbc into hashicorp:main Jun 27, 2023
@github-actions github-actions bot added this to the v3.63.0 milestone Jun 27, 2023
jackofallops added a commit that referenced this pull request Jun 27, 2023
@jackofallops
Update CHANGELOG for #21149
c68279d
@gabrieljoelc gabrieljoelc mentioned this pull request Oct 18, 2023
Open
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees

@jackofallops jackofallops

Labels
documentation enhancement service/container-apps size/S
Projects
None yet
Milestone
v3.63.0
5 participants
@jkrilov @jtatum @eugene-prout @jackofallops @tombuildsstuff