Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database - fix the value of max_size_gb overflow on 32-bit platform #21155

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Mar 28, 2023

The value of max_size_gb should be converted to int64 before multiplication to avoid int overflow on 32-bits platform.

Fix #18374

Test Result:
PASS: TestAccMsSqlDatabase_complete (852.56s)

@tombuildsstuff tombuildsstuff added this to the v3.50.0 milestone Mar 28, 2023
@tombuildsstuff tombuildsstuff merged commit c40d6a3 into hashicorp:main Mar 28, 2023
tombuildsstuff added a commit that referenced this pull request Mar 28, 2023
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
@sinbai sinbai deleted the mssql/fix_issue_18374 branch March 28, 2024 02:51
@sinbai sinbai restored the mssql/fix_issue_18374 branch March 28, 2024 02:51
@sinbai sinbai deleted the mssql/fix_issue_18374 branch March 28, 2024 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/mssql Microsoft SQL Server size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_mssql_database: valid max_size_gb reported as invalid
2 participants